Feature/ranking #19
Merged
Feature/ranking #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ralphbean
added a commit
to fedora-infra/fedbadges
that referenced
this pull request
Aug 19, 2013
This requires fedora-infra/tahrir-api#19. This is a fix for #19.
This was referenced Aug 19, 2013
This code and test will end up powering these two features: - fedora-infra/tahrir#163 - fedora-infra/tahrir#174
|
I promise this is the best pull request. Don't be scared... its totally reviewable! |
| self.session.flush() | ||
|
|
||
| if self.notification_callback: | ||
| self.notification_callback( |
There was a problem hiding this comment.
Above, we adjust the rank of numerous people but here we only emit a notification that the user who gained a badge had their rank updated. That doesn't seem right. Perhaps the topic should indicate that the person's rank has adjusted up? Everyone else's rank should either stay the same or adjust down.
There was a problem hiding this comment.
Agreed. I'll change the topic. It would be too spammy to publish a message every time a rank moves down.
|
Found some things to change. All comments are in the inline comments on the pull request. |
…ways be advancing, and we never emit messages for rank slipping).
|
All comments taken care of. Looks good. +1 to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is important for a number of issues filed on the main webapp repo. Notably, fedora-infra/tahrir#141.