Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here's a first pass at making
ViewController
a little more testable. I'm following the techniques I've outlined in Better Unit Testing with Swift, namely:First, I made
USPSManager
conform to a new protocol,PackageManager
. This allows us to create a mock for use under tests. Then, to make assertions easier, I moved the class methods to instance methods. Now the mock can record each parameter that was passed to it under test (and call the completion block with mock data!).This required opening up the
packageManager
variable onViewController
. Ideally, this would be alet
variable and injected via the initializer. However, I wasn't able to get this to work with storyboards so I figured a lazy-evaluatedvar
was a good tradeoff.Finally, the tests set up some mock package tracking information then assert that the table shows said data.