[NET] Invalid blocks from forks stored on disk fix + blocks DoS spam filter. #803

furszy · 2019-01-26T00:28:52Z

This PR mitigates the following problems:

Storage of invalid PoS/zPoS blocks from forked chains.
Blocks spam filtering.

Thanks to @random-zebra for the team work on this topic.

This work will be properly detailed on the next days of QA.

loop through forked blocks fix Invalid blocks from forks stored on disk Fix + Blocks DoS spam filter minor re organization minor cosmetic changes comments

… prev split main chain

src/main.cpp

meyer9

src/main.cpp

… max reorg limit

furszy · 2019-02-01T17:02:11Z

Yeah cool @cevap 👍 , we did it too. Preparing the final report and a new test suite that contains an expanded coverage of the characteristics of our blockchain. Hopefully will be ready soon.

The published vulnerability report is just the tip of this, not really covering our full specs.

… forks fixed

pwte · 2019-02-04T14:22:06Z

I tested your code main.cpp.zip on the Safeinsure blockchain, which contains this exception, with bootstrap and does not work properly, make the infinite loop!
debug.zip

furszy · 2019-02-04T14:33:43Z

Sorry @pwte , i cannot download external files or check other blockchain code. PIVX has plenty of forks, impossible to know what everyone is doing.
If you have an issue running it on PIVX, send the logs here and will check them. Or well, write what you found on a code's review.

Here it's working fine the PR and solves the base attack scenarios (still a work in progress and lots of tests that needs to be done)

pwte · 2019-02-04T15:26:20Z

Sorry @pwte , i cannot download external files or check other blockchain code. PIVX has plenty of forks, impossible to know what everyone is doing.
If you have an issue running it on PIVX, send the logs here and will check them. Or well, write what you found on a code's review.

Here it's working fine the PR and solves the base attack scenarios (still a work in progress and lots of tests that needs to be done)

You just can just look on the logs(debug.log)
You tried with bootstrap on PIVX blockchain?

Mrs-X · 2019-02-06T06:43:27Z

@pwte last night I bootstrapped a PIVX wallet without problems, so your exception is most probably related to your changes of the code.

pwte · 2019-02-06T09:42:22Z

@pwte last night I bootstrapped a PIVX wallet without problems, so your exception is most probably related to your changes of the code.

I'm glad to hear that.
The test was OK because so far the PIVX blockchain did not have the real situation where the transaction that generated the stake was spent on the fork.
I tested 19 blockchains(PIVX forks) and I found this exception only at safeinsure
Look at the logs above!

pwte · 2019-02-06T10:52:54Z

Everything you've done until now it's theoretical, you haven't tested on real situations

furszy · 2019-02-06T12:09:49Z

Actually, I have. This is not theoretical at all, we have a new test suite that it's running most of the possible scenarios. And it's working fine using this code.

Only zerocoin scenarios left to be completed and will be pushed here too.

And again, will not open logs from other projects. Impossible to know what code you have there. If you can replicate it on PIVX paste the log here, no files.

…de the same block

…ttps://github.com/furszy/PIVX into invalid_blocks_storage_and_blocks_DoS_spam_filter

preparing 3.2.0.5 Addresses https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2019-6250 Merge PIVX-Project/PIVX#803, addressing fake stake attack https://medium.com/@dsl_uiuc/fake-stake-attacks-on-chain-based-proof-of-stake-cryptocurrencies-b8b05723f806 # Conflicts: # src/main.cpp PR #803 Fake Stake merge Update "fake stake" patch Updating PR#803 from PIVX-Core addressing Fake Stake attack # Conflicts: # src/main.cpp

src/main.cpp

backport from PIVX-Project/PIVX#803

Fuzzbawls

ACK 61a6ea7

…ks DoS spam filter. 61a6ea7 AcceptBlock() for-each loops variables moved to const (furszy) e1974d2 AcceptBlock() check for double spent serials only on main chain flag. (furszy) babdfb0 remove extra debug lines in AcceptBlock (random-zebra) a9178bc AcceptBlock: contextual zcspend check on main chain (random-zebra) 0d49570 AcceptBlock() block stored log removed (furszy) b749217 Fix bug on AcceptBlock when pindex is null (random-zebra) 45883b9 AcceptBlock() invalid isBlockFromFork flag (furszy) 6a16049 AcceptBlock() reject blocks double spending the coin stake input inside the same block (furszy) da1b683 block spam filter, validate non null nodestate (furszy) 84de55a AcceptBlock() isBlockFromFork flag not contemplating prev blocks from forks fixed (furszy) 4219339 AcceptBlock() - not accept blocks from a forked chain that exceed the max reorg limit (furszy) 47759e1 AcceptBlock(), reject invalid PoS stake (furszy) e237823 validate non null pfrom on blockspamfilter check (furszy) c2e5459 AcceptBlock(), serial double spend on the same block validation (furszy) 3f50919 zPoS validations of forked chains before store them + inputs check on prev split main chain (furszy) 64804b4 Invalid blocks from forks stored on disk fix + blocks DoS spam filter. (furszy) Tree-SHA512: 6c5a7fda3eb81dc8b030c9ba624e5101f552ef9cecc839a79237b705c314171c0e9c66ecd8bfd207081c6759272140cf3bdf0da7af6ac4695f0c09b74fb1ba45

…d/PAWS-Core

These changes should fix the "fake stake" issue described at; https://pivx.org/fake-stake-official-pivx-report PIVX-Project#803

furszy added 2 commits January 25, 2019 19:31

Invalid blocks from forks stored on disk fix + blocks DoS spam filter.

64804b4

loop through forked blocks fix Invalid blocks from forks stored on disk Fix + Blocks DoS spam filter minor re organization minor cosmetic changes comments

zPoS validations of forked chains before store them + inputs check on…

3f50919

… prev split main chain

ghost assigned furszy Jan 26, 2019

ghost added the review label Jan 26, 2019

AcceptBlock(), serial double spend on the same block validation

c2e5459

furszy force-pushed the invalid_blocks_storage_and_blocks_DoS_spam_filter branch from 66ed1e6 to c2e5459 Compare January 26, 2019 21:29

pavik reviewed Jan 27, 2019

View reviewed changes

src/main.cpp Show resolved Hide resolved

validate non null pfrom on blockspamfilter check

e237823

pavik reviewed Jan 28, 2019

View reviewed changes

src/main.cpp Show resolved Hide resolved

AcceptBlock(), reject invalid PoS stake

47759e1

nashanas reviewed Jan 29, 2019

View reviewed changes

src/main.cpp Show resolved Hide resolved

nashanas reviewed Jan 29, 2019

View reviewed changes

src/main.cpp Outdated Show resolved Hide resolved

meyer9 suggested changes Jan 30, 2019

View reviewed changes

src/main.cpp Show resolved Hide resolved

src/main.cpp Show resolved Hide resolved

AcceptBlock() - not accept blocks from a forked chain that exceed the…

4219339

… max reorg limit

Fuzzbawls added this to the 3.2.0 milestone Jan 31, 2019

Fuzzbawls added High Priority Block Storage Validation Needs Release Notes Placeholder tag for anything needing mention in the "Notable Changes" section of release notes labels Jan 31, 2019

PIVX-Project deleted a comment from jonspock Jan 31, 2019

furszy added 2 commits February 4, 2019 03:03

AcceptBlock() isBlockFromFork flag not contemplating prev blocks from…

84de55a

… forks fixed

block spam filter, validate non null nodestate

da1b683

AcceptBlock() invalid isBlockFromFork flag

45883b9

furszy and others added 4 commits February 7, 2019 13:12

AcceptBlock() reject blocks double spending the coin stake input insi…

6a16049

…de the same block

Merge branch 'invalid_blocks_storage_and_blocks_DoS_spam_filter' of h…

97c266b

…ttps://github.com/furszy/PIVX into invalid_blocks_storage_and_blocks_DoS_spam_filter

Fix bug on AcceptBlock when pindex is null

b749217

AcceptBlock() block stored log removed

0d49570

furszy force-pushed the invalid_blocks_storage_and_blocks_DoS_spam_filter branch from d90d307 to 0d49570 Compare February 8, 2019 14:10

random-zebra and others added 3 commits February 8, 2019 15:49

AcceptBlock: contextual zcspend check on main chain

a9178bc

remove extra debug lines in AcceptBlock

babdfb0

AcceptBlock() check for double spent serials only on main chain flag.

e1974d2

WagerrTor mentioned this pull request Feb 11, 2019

Invalid blocks storage and blocks do s spam filter wagerr/wagerr#113

Merged

furszy mentioned this pull request Feb 11, 2019

[Regtest][Tests][RPC] Regtest mode + Test suite. #812

Merged

j00v added a commit to j00v/MNPCoin that referenced this pull request Feb 12, 2019

Merged PIVX-Project/PIVX#803

4e634da

random-zebra self-assigned this Feb 15, 2019

presstab reviewed Feb 21, 2019

View reviewed changes

src/main.cpp Outdated Show resolved Hide resolved

royhodge mentioned this pull request Feb 24, 2019

enable enforcement so it doesnt take the whole block as POS MeroCoin/mero#3

Closed

ghost pushed a commit to DSTRACoin/dstra that referenced this pull request Feb 24, 2019

Invalid blocks from forks stored on disk fix + blocks DoS spam filter

df53343

backport from PIVX-Project/PIVX#803

AcceptBlock() for-each loops variables moved to const

61a6ea7

furszy changed the title ~~[WIP] [NET] Invalid blocks from forks stored on disk fix + blocks DoS spam filter.~~ [NET] Invalid blocks from forks stored on disk fix + blocks DoS spam filter. Feb 24, 2019

Fuzzbawls approved these changes Feb 25, 2019

View reviewed changes

Fuzzbawls merged commit 61a6ea7 into PIVX-Project:master Feb 25, 2019

ghost removed the review label Feb 25, 2019

Fuzzbawls removed Needs Release Notes Placeholder tag for anything needing mention in the "Notable Changes" section of release notes labels Mar 23, 2019

carebitcoin added a commit to carebitcoin/carebitcoin that referenced this pull request Apr 9, 2019

Merged PIVX-Project/PIVX#803 and added extra mitigations from pawsfun…

b8bd5ce

…d/PAWS-Core

lyricidal mentioned this pull request Aug 5, 2022

[Upstream] [NET] Invalid blocks from forks stored on disk fix + blocks DoS spam filter. PRCYCoin/PRCYCoin#242

Merged

furszy deleted the invalid_blocks_storage_and_blocks_DoS_spam_filter branch May 27, 2023 01:57

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[NET] Invalid blocks from forks stored on disk fix + blocks DoS spam filter. #803

[NET] Invalid blocks from forks stored on disk fix + blocks DoS spam filter. #803

furszy commented Jan 26, 2019

meyer9 left a comment •

edited by furszy

furszy commented Feb 1, 2019

pwte commented Feb 4, 2019

furszy commented Feb 4, 2019

pwte commented Feb 4, 2019

Mrs-X commented Feb 6, 2019

pwte commented Feb 6, 2019

pwte commented Feb 6, 2019

furszy commented Feb 6, 2019

Fuzzbawls left a comment

[NET] Invalid blocks from forks stored on disk fix + blocks DoS spam filter. #803

[NET] Invalid blocks from forks stored on disk fix + blocks DoS spam filter. #803

Conversation

furszy commented Jan 26, 2019

meyer9 left a comment • edited by furszy

Choose a reason for hiding this comment

furszy commented Feb 1, 2019

pwte commented Feb 4, 2019

furszy commented Feb 4, 2019

pwte commented Feb 4, 2019

Mrs-X commented Feb 6, 2019

pwte commented Feb 6, 2019

pwte commented Feb 6, 2019

furszy commented Feb 6, 2019

Fuzzbawls left a comment

Choose a reason for hiding this comment

meyer9 left a comment •

edited by furszy