Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Full Site Editing: deploy the plugin to WP.com [5] #33163

Closed
vindl opened this issue May 20, 2019 · 3 comments
Closed

Full Site Editing: deploy the plugin to WP.com [5] #33163

vindl opened this issue May 20, 2019 · 3 comments
Assignees
@vindl
Labels
[Goal] Full Site Editing [Type] Task
Milestone
Cylon Sprint [21-22]

Comments

@vindl
Copy link
Member

vindl commented May 20, 2019 •
edited

We need to find a way to run the plugin code on Dotcom behind something that would simulate a feature flag and enable it only on some sites for initial testing.

Previous efforts to do this ran into some issues because of the loading order and blog_sticker checks (see D28074-code for more info).
@vindl vindl added this to the Cylon Sprint [21-22] milestone May 20, 2019
@vindl vindl changed the title Full Site Editing: deploy the plugin to WP.com [5] Full Site Editing: deploy the plugin to WP.com [?] May 20, 2019
@vindl vindl mentioned this issue May 20, 2019
Closed
@vindl vindl changed the title Full Site Editing: deploy the plugin to WP.com [?] Full Site Editing: deploy the plugin to WP.com [5] May 20, 2019
@Copons
Copy link
Contributor

Copons commented May 22, 2019 •
edited

I'm wondering if a Calypsoify approach would work for us: adding a query param that saves the option into a cookie until explicitly removed.
E.g. opening the dashboard via proxied-sandbox.wordpress.com/wp-admin/?full_site_editing=1 (or 0 to disable it).

Folks would need to clearly opt-in, so that they wouldn't be confused of what they see.
At the same time, they wouldn't need the hassle of adding their site ID into a whitelist.

(And last but not least, we already have a working example to copy.)

@vindl
Copy link
Member Author

vindl commented May 22, 2019

Nice idea @Copons! Yeah, I think this might work out.

@vindl vindl self-assigned this May 27, 2019
@vindl
Copy link
Member Author

vindl commented May 30, 2019

Resolved in D28892-code.

@vindl vindl closed this as completed May 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vindl vindl

Labels
[Goal] Full Site Editing [Type] Task
Projects
None yet
Milestone
Cylon Sprint [21-22]
Development

No branches or pull requests
2 participants
@vindl @Copons