Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add an edit button to embed blocks #8084

Merged
merged 2 commits into from Jul 26, 2018
Merged

Add an edit button to embed blocks #8084

merged 2 commits into from Jul 26, 2018

Conversation

notnownikki
Copy link
Member

@notnownikki notnownikki commented Jul 20, 2018 •
edited

Description

Adds an edit button to the embed blocks, so you can change the URL.

How has this been tested?

Embed some content, click the edit button, change the URL, embed again.

Types of changes

New feature

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.

@notnownikki notnownikki mentioned this pull request Jul 20, 2018
Closed
2 tasks
@notnownikki
Copy link
Member Author

Rebased to pick up the alignment toolbar changes

@gziolo gziolo added [Feature] Blocks Overall functionality of blocks [Type] Enhancement A suggestion for improvement. labels Jul 26, 2018
@gziolo
Copy link
Member

gziolo commented Jul 26, 2018

Code wise it looks good. However, there is some visual issue which needs to be fixed before we proceed:

screen shot 2018-07-26 at 12 50 05

Browser: Chrome, macOS.

gziolo
gziolo requested changes Jul 26, 2018
View reviewed changes
Copy link
Member

@gziolo gziolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code wise it looks good. However, there are some visual issues which need to be fixed before we proceed:

screen shot 2018-07-26 at 12 50 05

screen shot 2018-07-26 at 12 53 05

Browser: Chrome, macOS.

@notnownikki
Copy link
Member Author

I wonder if this is an issue with mixing supports and BlockControls in the same block. I'll take a look!

@notnownikki
Copy link
Member Author

Wrapped the edit control in Toolbar, seems to fix it. Perhaps I missed something in a past change, I'm sure this used to happen automatically...

gziolo
gziolo approved these changes Jul 26, 2018
View reviewed changes
Copy link
Member

@gziolo gziolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing, all good after your change. 🚢

@gziolo gziolo added this to the 3.4 milestone Jul 26, 2018
@notnownikki notnownikki merged commit ac89b86 into master Jul 26, 2018
@youknowriad youknowriad deleted the update/edit-embed-url branch July 26, 2018 12:06
@mtias
Copy link
Member

mtias commented Aug 2, 2018

Nice small improvement, thanks!

@dependabot-preview dependabot-preview bot mentioned this pull request Dec 31, 2019
Closed
@dependabot-preview dependabot-preview bot mentioned this pull request Feb 4, 2020
Merged
@dependabot-preview dependabot-preview bot mentioned this pull request Apr 15, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gziolo gziolo gziolo approved these changes

@youknowriad youknowriad Awaiting requested review from youknowriad

Assignees
No one assigned
Labels
[Feature] Blocks Overall functionality of blocks [Type] Enhancement A suggestion for improvement.
Projects
None yet
Milestone
3.4
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@notnownikki @gziolo @mtias