Skip to content

Commit

Permalink
Repeat ampli's fix (described below) for other occurances on the site.
Browse files Browse the repository at this point in the history
  ``The Save buttons in the two first steps didn't work in Chrome.
    According to a hint in the YUI Button documentation about a problem in using
    "submit" as a value of the name attribute, I changed submit button name
    in the two first steps from "submit" to "send".  This solved the problem.''
  • Loading branch information
scottwalters committed Jun 29, 2011
1 parent ebbbeb6 commit 54ae754
Show file tree
Hide file tree
Showing 27 changed files with 44 additions and 44 deletions.
2 changes: 1 addition & 1 deletion lib/WebGUI/Account/FriendManager.pm
Expand Up @@ -253,7 +253,7 @@ sub www_editFriends {
if (!$groupName) {
$fb->addField( "Checkbox", name => 'addManagers', value => 'addManagers' );
}
$fb->addField( 'Submit', name => "submit" );
$fb->addField( 'Submit', name => "send" );
$fb->toTemplateVars( "form_", $var );

return $self->processTemplate($var,$session->setting->get("fmEditTemplateId"));
Expand Down
2 changes: 1 addition & 1 deletion lib/WebGUI/Asset/EMSSubmission.pm
Expand Up @@ -422,7 +422,7 @@ sub www_editSubmission {
);
}
}
$newform->addField( "submit", name => "submit" );
$newform->addField( "submit", name => "send" );
my $title = $asset->get('title');
my $content =
$asset->processTemplate({
Expand Down
2 changes: 1 addition & 1 deletion lib/WebGUI/Asset/EMSSubmissionForm.pm
Expand Up @@ -287,7 +287,7 @@ sub www_editSubmissionForm {
value => $formDescription->{ $field->{fieldId} },
);
}
$newform->addField( "submit", name => "submit" );
$newform->addField( "submit", name => "send" );
my $title = $assetId eq 'new' ? $i18n->get('new form') || 'new' : $asset->get('title');
if ( $params->{asHashRef} ) {
; # not setting mimie type
Expand Down
2 changes: 1 addition & 1 deletion lib/WebGUI/Asset/File/Image.pm
Expand Up @@ -366,7 +366,7 @@ sub www_annotate {
-value=>$i18n->get('annotate'),
-extras=>'onclick="switchState();"',
);
$f->addField( "submit", name => "submit" );
$f->addField( "submit", name => "send" );
my ($crop_js, $domMe) = $self->annotate_js();
my $output = '<h1>' . $i18n->get('annotate image') . '</h1>' . $f->toHtml . $image . $crop_js . $domMe;
return $style->process( $output, "PBtmplBlankStyle000001" );
Expand Down
2 changes: 1 addition & 1 deletion lib/WebGUI/Asset/MatrixListing.pm
Expand Up @@ -324,7 +324,7 @@ sub getEditForm {
}

my $buttons = $form->addField( "ButtonGroup", name => "saveButtons", rowClass => "saveButtons" );
$buttons->addButton( "Submit", name => "submit" );
$buttons->addButton( "Submit", name => "send" );
$buttons->addButton( "Button",
name => "cancel",
value => $i18n->get('cancel', 'WebGUI'),
Expand Down
2 changes: 1 addition & 1 deletion lib/WebGUI/Asset/Shortcut.pm
Expand Up @@ -1208,7 +1208,7 @@ sub www_editOverride {
value => $overrides{overrides}{$fieldName}{parsedValue},
hoverHelp => $i18n->get("This is the example output of the field when parsed for user preference macros")
) if $self->isDashlet;
$f->addField( "submit", name => "submit" );
$f->addField( "submit", name => "send" );

$output .= $f->toHtml;

Expand Down
12 changes: 6 additions & 6 deletions lib/WebGUI/Asset/Sku/Product.pm
Expand Up @@ -941,7 +941,7 @@ sub www_addAccessory {
label => $i18n->get(18),
hoverHelp => $i18n->get('18 description'),
);
$f->addField( "submit" );
$f->addField( "submit", name => "send" );

return $f->toHtml;
}
Expand Down Expand Up @@ -1023,7 +1023,7 @@ sub www_addRelated {
label => $i18n->get(21),
hoverHelp => $i18n->get('21 description'),
);
$f->addField( "submit", name => "submit" );
$f->addField( "submit", name => "send" );
return $f->toHtml;
}

Expand Down Expand Up @@ -1218,7 +1218,7 @@ sub www_editBenefit {
label => $i18n->get(52),
hoverHelp => $i18n->get('52 description'),
);
$f->addField( "submit", name => "submit" );
$f->addField( "submit", name => "send" );
return $f->toHtml;
}

Expand Down Expand Up @@ -1281,7 +1281,7 @@ sub www_editFeature {
label => $i18n->get(24),
hoverHelp => $i18n->get('24 description'),
);
$f->addField( "submit", name => "submit" );
$f->addField( "submit", name => "send" );
return $f->toHtml;
}

Expand Down Expand Up @@ -1358,7 +1358,7 @@ sub www_editSpecification {
label => $i18n->get(28),
hoverHelp => $i18n->get('28 description'),
);
$f->addField( "submit", name => "submit" );
$f->addField( "submit", name => "send" );
return $f->toHtml;
}

Expand Down Expand Up @@ -1449,7 +1449,7 @@ sub www_editVariant {
label => $i18n->get('add another variant'),
hoverHelp => $i18n->get('add another variant description'),
);
$f->addField( "submit", name => "submit" );
$f->addField( "submit", name => "send" );
return $f->toHtml;
}

Expand Down
6 changes: 3 additions & 3 deletions lib/WebGUI/Asset/Sku/Subscription.pm
Expand Up @@ -593,7 +593,7 @@ sub www_createSubscriptionCodeBatch {

# Generate the properties form for this subscription code batch
my $f = WebGUI::FormBuilder->new( $session, action => $self->getUrl );
$f->addField( "submit", name => "submit" );
$f->addField( "submit", name => "send" );
$f->addField( "hidden",
name => 'func',
value => 'createSubscriptionCodeBatchSave'
Expand Down Expand Up @@ -628,7 +628,7 @@ sub www_createSubscriptionCodeBatch {
hoverHelp => $i18n->get('batch description description'),
value => $session->form->process("description"),
);
$f->addField( "submit", name => "submit" );
$f->addField( "submit", name => "send" );

return $errorMessage.$f->toHtml;
}
Expand Down Expand Up @@ -1016,7 +1016,7 @@ sub www_redeemSubscriptionCode {
-maxLength => 64,
-size => 30
);
$f->addField( "submit", name => "submit" );
$f->addField( "submit", name => "send" );
$var->{ codeForm } = $f->toHtml;

return $self->processStyle($self->processTemplate($var, $self->redeemSubscriptionCodeTemplateId));
Expand Down
4 changes: 2 additions & 2 deletions lib/WebGUI/Asset/Wobject/DataForm.pm
Expand Up @@ -1610,7 +1610,7 @@ sub www_editField {
value => "editField"
);
}
$f->addField( "submit", name => "submit" );
$f->addField( "submit", name => "send" );
return '<h1>' . $i18n->get('20') . '</h1>' . $f->toHtml;
}

Expand Down Expand Up @@ -1813,7 +1813,7 @@ sub www_editTab {
-value=>"editTab"
);
}
$f->addField( "submit", name => "submit" );
$f->addField( "submit", name => "send" );
return '<h1>' . $i18n->get('103') . '</h1>' . $f->toHtml if $tabId eq "new";
return '<h1>' . $i18n->get('102') . '</h1>' . $f->toHtml;
}
Expand Down
10 changes: 5 additions & 5 deletions lib/WebGUI/Asset/Wobject/EventManagementSystem.pm
Expand Up @@ -1007,7 +1007,7 @@ sub www_editBadgeGroup {
label => $i18n->get('badge group name'),
hoverHelp => $i18n->get('badge group name help'),
);
$f->addField( "submit", name => "submit" );
$f->addField( "submit", name => "send" );
return $self->processStyle('<h1>'.$i18n->get('badge groups').'</h1>'.$f->toHtml);
}

Expand Down Expand Up @@ -1180,7 +1180,7 @@ sub www_editEventMetaField {
hoverHelp => $i18n2->get('meta field help text description'),
value => $data->{helpText},
);
$f->addField( "submit", name => "submit" );
$f->addField( "submit", name => "send" );
return $self->processStyle($f->toHtml);
}

Expand Down Expand Up @@ -2044,7 +2044,7 @@ sub www_importEvents {
value => scalar $form->get('fieldsToImport'),
);

$f->addField( "submit", name => "submit", value=>$i18n->get('import events'));
$f->addField( "submit", name => "send", value=>$i18n->get('import events'));

return $self->processStyle($page_header.'<p/>'.$f->toHtml);
}
Expand Down Expand Up @@ -2295,7 +2295,7 @@ sub www_manageRegistrant {

# build form
my $f = WebGUI::FormBuilder->new($session, action=>$self->getUrl, extras=>'class="manageRegistrant"');
$f->addField( "submit", name => "submit" );
$f->addField( "submit", name => "send" );
$f->addField( "hidden",name=>"func", value=>"editRegistrantSave");
$f->addField( "hidden",name=>'badgeId', value=>$badgeId);
$f->addField( "readOnly",
Expand Down Expand Up @@ -2365,7 +2365,7 @@ sub www_manageRegistrant {
label => $i18n->get('notes'),
defaultValue => $registrant->{notes}
);
$f->addField( "submit", name => "submit" );
$f->addField( "submit", name => "send" );

# build html
my $output = q|
Expand Down
4 changes: 2 additions & 2 deletions lib/WebGUI/Asset/Wobject/InOutBoard.pm
Expand Up @@ -245,7 +245,7 @@ sub view {
-name=>"func",
-value=>"setStatus"
);
$f->addField( "submit", name => "submit" );
$f->addField( "submit", name => "send" );

my ($isInGroup) = $session->db->quickArray(
"select count(*) from groupings where userId=? and groupId=?",
Expand Down Expand Up @@ -368,7 +368,7 @@ sub www_selectDelegates {
value => $delegates, ##My current delegates, if any
subtext => $i18n->get('in/out status delegates subtext'),
);
$f->addField( "submit", name => "submit" );
$f->addField( "submit", name => "send" );
return '<h1>' . $i18n->get('select delegate') . '</h1> ' . $f->toHtml;
}

Expand Down
2 changes: 1 addition & 1 deletion lib/WebGUI/Asset/Wobject/Survey.pm
Expand Up @@ -2820,7 +2820,7 @@ sub www_editTest {
$form->addField( "hidden", name=>"testId", value=>$testId);
$form->addField( "hidden", name=>"assetId", value=>$self->getId);
$test->crud_form($form, $test);
$form->addField( "submit", name => "submit" );
$form->addField( "submit", name => "save" );

if ($testId eq 'new') {
$test->delete;
Expand Down
2 changes: 1 addition & 1 deletion lib/WebGUI/Asset/Wobject/Thingy.pm
Expand Up @@ -3399,7 +3399,7 @@ sub www_importForm {
}
$fieldOptions .= "</table>";
$form->addField( "ReadOnly", name => 'fieldOptions', value => $fieldOptions );
$form->addField( "submit", name => "submit" );
$form->addField( "submit", name => "send" );

$output .= $form->toHtml;
return $self->processStyle($output);
Expand Down
2 changes: 1 addition & 1 deletion lib/WebGUI/AssetHelper/ChangeUrl.pm
Expand Up @@ -88,7 +88,7 @@ sub www_changeUrl {
hoverHelp=> $i18n->get("confirm change url message"),
subtext => '<br />'.$i18n->get("confirm change url message")
);
$f->addField( "submit", name => "submit" );
$f->addField( "submit", name => "send" );
return $f->toHtml;
}

Expand Down
2 changes: 1 addition & 1 deletion lib/WebGUI/AssetHelper/ExportHtml.pm
Expand Up @@ -134,7 +134,7 @@ ENDHTML
'none' => $i18n->get('rootUrl form option none') },
value => ['none'],
);
$f->addField( "submit", name => "submit" );
$f->addField( "submit", name => "send" );
my $message;
eval { $asset->exportCheckPath };
if($@) {
Expand Down
2 changes: 1 addition & 1 deletion lib/WebGUI/AssetHelper/Image/Crop.pm
Expand Up @@ -127,7 +127,7 @@ sub www_crop {
-name => "Left",
-value => $y,
);
$f->addField( "submit", name => "submit" );
$f->addField( "submit", name => "send" );

my $image
= '<div align="center" class="yui-skin-sam"><img src="'
Expand Down
2 changes: 1 addition & 1 deletion lib/WebGUI/AssetHelper/Image/Resize.pm
Expand Up @@ -119,7 +119,7 @@ sub www_resize {
name => "newHeight",
value => $y,
);
$f->addField( "submit", name => "submit" );
$f->addField( "submit", name => "send" );
my $image
= '<div align="center" class="yui-skin-sam"><img src="'
. $asset->getStorageLocation->getUrl( $asset->filename )
Expand Down
2 changes: 1 addition & 1 deletion lib/WebGUI/AssetHelper/Image/Rotate.pm
Expand Up @@ -69,7 +69,7 @@ sub www_rotate {
name=>"Rotate",
value=>0,
);
$f->addField( "submit", name => "submit" );
$f->addField( "submit", name => "send" );

my $output = '<h1>' . $i18n->get("rotate image") . '</h1>' . $f->toHtml . $image;
return $style->process( $output, "PBtmplBlankStyle000001" );
Expand Down
2 changes: 1 addition & 1 deletion lib/WebGUI/AssetHelper/Product/ImportCSV.pm
Expand Up @@ -228,7 +228,7 @@ sub www_importProducts {

my $f = $self->getForm( 'importProductsSave' );
$f->addField( 'file', name => 'importFile' );
$f->addField( 'submit', name => 'submit', value => $i18n->get('import') );
$f->addField( 'submit', name => 'send', value => $i18n->get('import') );

return $session->style->process(
'<h1>' . $i18n->get('import') . '</h1>' . $f->toHtml,
Expand Down
2 changes: 1 addition & 1 deletion lib/WebGUI/AssetMetaData.pm
Expand Up @@ -436,7 +436,7 @@ sub www_editMetaDataField {
hoverHelp=>$i18n->get('default value description'),
value=>$fieldInfo->{defaultValue}
);
$f->addField( "submit", name => "submit" );
$f->addField( "submit", name => "send" );
return '<h1>' . $i18n->get('Edit Metadata') . '</h1>' . $f->toHtml;
}

Expand Down
2 changes: 1 addition & 1 deletion lib/WebGUI/Operation/Workflow.pm
Expand Up @@ -388,7 +388,7 @@ sub www_editWorkflowActivity {
$form->action( $session->url->page );
$form->addField( "hidden", name=>"op", value=>"editWorkflowActivitySave");
$form->addField( "hidden", name=>"workflowId", value=> scalar $session->form->get("workflowId"));
$form->addField( "submit", name => "submit" );
$form->addField( "submit", name => "send" );
my $i18n = WebGUI::International->new($session, "Workflow");
my $ac = WebGUI::AdminConsole->new($session,"workflow");
$ac->addSubmenuItem($session->url->page("op=addWorkflow"), $i18n->get("add a new workflow"));
Expand Down
4 changes: 2 additions & 2 deletions lib/WebGUI/Shop/PayDriver.pm
Expand Up @@ -371,7 +371,7 @@ sub getEditForm {
my $self = shift;

my $form = WebGUI::FormBuilder->new($self->session);
$form->addField( "submit", name => "submit" );
$form->addField( "submit", name => "send" );

$self->getDoFormTags('editSave', $form);
$form->addField( "hidden",
Expand Down Expand Up @@ -658,7 +658,7 @@ sub www_edit {

my $form = $self->getEditForm;
$form->addField( 'csrfToken', name => 'csrfToken' );
$form->addField( "submit", name => "submit" );
$form->addField( "submit", name => "send" );

return '<h1>' . $i18n->get('payment methods') . '</h1>' . $form->toHtml;
}
Expand Down
2 changes: 1 addition & 1 deletion lib/WebGUI/Shop/PayDriver/Ogone.pm
Expand Up @@ -418,7 +418,7 @@ sub www_edit {

my $form = $self->getEditForm;
$form->addField( 'csrfToken', name => 'csrfToken' );
$form->addField( "submit", name => "submit" );
$form->addField( "submit", name => "send" );

my $processUrl = $self->session->url->getSiteURL.'/?shop=pay&method=do&do=processTransaction&paymentGatewayId='.$self->getId;
my $output = '<br />';
Expand Down
4 changes: 2 additions & 2 deletions lib/WebGUI/Shop/ShipDriver.pm
Expand Up @@ -201,7 +201,7 @@ sub getEditForm {
my $self = shift;

my $form = WebGUI::FormBuilder->new($self->session, action => $self->session->url->page );
$form->addField( "submit", name => "submit" );
$form->addField( "submit", name => "send" );

$form->addField( "hidden", name => 'shop', value => "ship");
$form->addField( "hidden", name => 'method', value => "do");
Expand Down Expand Up @@ -328,7 +328,7 @@ sub www_edit {
my $admin = WebGUI::Shop::Admin->new($session);
my $i18n = WebGUI::International->new($session, "Shop");
my $form = $self->getEditForm;
$form->addField( "submit", name => "submit" );
$form->addField( "submit", name => "send" );
$form->addField( 'csrfToken', name => 'webguiCsrfToken' );
return '<h1>' . $i18n->get("shipping methods") . '</h1>' . $form->toHtml;
}
Expand Down
4 changes: 2 additions & 2 deletions lib/WebGUI/Shop/TaxDriver/EU.pm
Expand Up @@ -349,7 +349,7 @@ sub getEditForm {
hoverHelp => $i18n->get('accept when vies unavailable help'),
);

$f->addField( "submit", name => "submit" );
$f->addField( "submit", name => "send" );
my $general = $f->toHtml;

# VAT groups manager
Expand All @@ -364,7 +364,7 @@ sub getEditForm {
. $i18n->get('rate')
. WebGUI::Form::float( $session, { name => 'rate' } )
. '%'
. WebGUI::Form::submit( $session, { name => 'submit', value => 'Add' } )
. WebGUI::Form::submit( $session, { name => 'send', value => 'Add' } )
. WebGUI::Form::formFooter( $session );

# Wrap output in a YUI Tab widget.
Expand Down
4 changes: 2 additions & 2 deletions lib/WebGUI/Wizard/Setup.pm
Expand Up @@ -311,11 +311,11 @@ sub www_siteStats {

my $enableForm = $self->getForm;
$enableForm->addField( "hidden", name => "enableStats", value => 1 );
$enableForm->addField( "submit", name => 'submit', value => $i18n->get( 'enable', 'Activity_SendWebguiStats' ) );
$enableForm->addField( "submit", name => 'send', value => $i18n->get( 'enable', 'Activity_SendWebguiStats' ) );

my $disableForm = $self->getForm;
$disableForm->addField( "hidden", name => "enableStats", value => 0 );
$disableForm->addField( "submit", name => 'submit', value => $i18n->get( 'disable', 'Activity_SendWebguiStats' ) );
$disableForm->addField( "submit", name => 'send', value => $i18n->get( 'disable', 'Activity_SendWebguiStats' ) );

my $output = '<h1>' . $i18n->get( 'topicName', 'Activity_SendWebguiStats' ) . '</h1>';
$output .= ' <p>' . $i18n->get( 'why to send', 'Activity_SendWebguiStats' ) . '</p>
Expand Down
2 changes: 1 addition & 1 deletion lib/WebGUI/Workflow/Activity.pm
Expand Up @@ -236,7 +236,7 @@ Returns the form that will be used to edit the properties of an activity.
sub getEditForm {
my $self = shift;
my $form = WebGUI::FormBuilder->new($self->session);
$form->addField( "submit", name => "submit" );
$form->addField( "submit", name => "send" );
$form->addField( "hidden", name=>"activityId", value=>$self->getId);
$form->addField( "hidden", name=>"className", value=>$self->get("className"));
my $fullDefinition = $self->definition($self->session);
Expand Down

0 comments on commit 54ae754

Please sign in to comment.