make function return void

shogun-toolbox · Jul 17, 2011 · 3de2daa · 3de2daa
1 parent 4d12457
commit 3de2daa
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 13 deletions.
diff --git a/src/libshogun/kernel/WeightedDegreePositionStringKernel.cpp b/src/libshogun/kernel/WeightedDegreePositionStringKernel.cpp
@@ -925,29 +925,21 @@ bool CWeightedDegreePositionStringKernel::set_weights(SGMatrix<float64_t> new_we
 	return true;
 }
 
-bool CWeightedDegreePositionStringKernel::set_position_weights(SGVector<float64_t> pws)
+void CWeightedDegreePositionStringKernel::set_position_weights(SGVector<float64_t> pws)
 {
 	if (seq_length==0)
 		seq_length=pws.vlen;
 
 	if (seq_length!=pws.vlen)
-	{
 		SG_ERROR("seq_length = %i, position_weights_length=%i\n", seq_length, pws.vlen);
-		return false;
-	}
+
 	delete[] position_weights;
 	position_weights=new float64_t[pws.vlen];
 	position_weights_len=pws.vlen;
 	tries.set_position_weights(position_weights);
 
-	if (position_weights)
-	{
-		for (int32_t i=0; i<pws.vlen; i++)
-			position_weights[i]=pws.vector[i];
-		return true;
-	}
-	else
-		return false;
+	for (int32_t i=0; i<pws.vlen; i++)
+		position_weights[i]=pws.vector[i];
 }
 
 bool CWeightedDegreePositionStringKernel::set_position_weights_lhs(float64_t* pws, int32_t len, int32_t num)

diff --git a/src/libshogun/kernel/WeightedDegreePositionStringKernel.h b/src/libshogun/kernel/WeightedDegreePositionStringKernel.h
@@ -392,7 +392,7 @@ class CWeightedDegreePositionStringKernel: public CStringKernel<char>
 		 * @param pws new position weights
 		 * @return if setting was successful
 		 */
-		virtual bool set_position_weights(SGVector<float64_t> pws);
+		virtual void set_position_weights(SGVector<float64_t> pws);
 
 		/** set position weights for left-hand side
 		 *