Chromium Main Console
Legend: | Passed | Failed | Running | Exception |
Service worker web platform tests.
This tests that when an auction is ran, service workers do not intercept requests with URLs that are meant to be private.
Bug: 293383734
Change-Id: I06858f7cae4794a35c045fb8dad30d6316a26ead
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5459094
Commit-Queue: Youssef Bourouphael <ybourouphael@google.com>
Reviewed-by: mmenke <mmenke@chromium.org>
Reviewed-by: Orr Bernstein <orrb@google.com>
Cr-Commit-Position: refs/heads/main@{#1294960}
[Extensions] Change service worker task readiness check.
This removes the registration aspect of the task queue's readiness
check.
Before this change it was implemented in 2018[1]. There's no
documentation there on why it was needed, nor in the design doc[2]. We
also don't change it when we deactivate an extension so it's not about a
race on worker deactivation to prevent tasks from being sent to the
worker after it's been deactivated. DeactivateExtension() deletes the
WorkerState which means WorkerState::ready() wouldn't be able to be
called anyways.
My testing found that it *is* necessary to check this before starting a
worker (which is handled in AddPendingTask() where we bail out before
starting the worker). This is because a registration must be found while
starting the worker or we'll hit DidStartWorkerFail() with
blink::ServiceWorkerStatusCode::kErrorNotFound. If we do try to
AddPendingTask() before the worker is registered,
DidRegisterServiceWorker() will handle this by starting the worker which
eventually runs the pending task.
Since we can't start a worker without checking for the registration and
we also can't dispatch tasks after the worker becomes unregistered
(DeactivateExtension() removes the WorkerState so WorkerState::ready()
can't be called), it seems redundant to check it again every time we
dispatch an event.
[1]: crrev.com/c/1970854
[2]: https://docs.google.com/document/d/17Y-MKaciEpNmZm8K-TKXQF3zR_YHQZzkkvT6qabmvh4/edit?usp=sharing
Bug: 40276609
Change-Id: I3d37f58a523fbf91e80bad1955693cd98d57519f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5499098
Auto-Submit: Justin Lulejian <jlulejian@chromium.org>
Reviewed-by: Devlin Cronin <rdevlin.cronin@chromium.org>
Commit-Queue: Justin Lulejian <jlulejian@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1294959}
Add interop coverage for aggregation coordinator origin
We require the default configuration to specify at least one coordinator
origin, and allow individual tests to override the allowlist.
Change-Id: I5b1802770442c96cc20ec65bb4eef13b253d83c1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5498755
Reviewed-by: Nan Lin <linnan@chromium.org>
Commit-Queue: Andrew Paseltiner <apaseltiner@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1294958}
Graphite: Add histograms for cache hit/miss counts 90s after startup
Add histograms for Dawn pipeline cache hits and misses counters that
are logged 90sec after browser startup.
Bug: dawn:2533
Change-Id: I5f7cc46d79758b576474ce961ee344d2ba161fdb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5490189
Reviewed-by: Austin Eng <enga@chromium.org>
Reviewed-by: Jonathan Ross <jonross@chromium.org>
Commit-Queue: Saifuddin Hitawala <hitawala@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1294957}
Fix target_cpu for mac-pgo builder
The mac-pgo builder now runs on arm64 after crrev.com/i/7114055,
but we still want it to generate x64 code.
Bug: 332251597
Change-Id: I9c448ef100a60d32ae1fc8eaec10a2342ead468e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5502787
Commit-Queue: John Chen <johnchen@chromium.org>
Reviewed-by: Jeff Yoon <jeffyoon@google.com>
Reviewed-by: Ben Pastene <bpastene@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1294956}
Don't show deep scan notice if deep scanning has happened automatically
The phrasing "The next time Google Safe Browsing..." is no longer that
accurate, so stop showing the notice.
This is a bit of an edge case, given that the notice disappears when the
previous deep scan prompt is resolved through either:
- User accepts/rejects the prompt
- User closes the browser
- The prompt times out (1 hour)
Bug: 335312766
Change-Id: Ic556a9a03388faa1432433695819ef0ed211c19d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5478651
Reviewed-by: Lily Chen <chlily@chromium.org>
Commit-Queue: Daniel Rubery <drubery@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1294955}
[FedCM] Record metrics for parameters and scopes
R=yigu@chromium.org
Bug: 324104289
Change-Id: Ia4a412736338e050d514004d4b65b33f29441da0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5502572
Auto-Submit: Christian Biesinger <cbiesinger@chromium.org>
Commit-Queue: Christian Biesinger <cbiesinger@chromium.org>
Reviewed-by: Yi Gu <yigu@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1294954}
Roll Chromium Variations from 143cd4339d62 to 99987faaaa9e (24 revisions)
https://chromium.googlesource.com/chromium-variations.git/+log/143cd4339d62..99987faaaa9e
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-variations-chromium
Please CC chrome-metrics-team@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium Variations: https://bugs.chromium.org/p/chromium/issues/entry
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: chrome-metrics-team@google.com
Change-Id: I158837c35e0753e8c41038b4453da88005d13cc5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5503943
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1294953}
Add access to ProduceSpecificationSet observer events for webui
This patch makes the ShoppingServiceHandler an observer of the
ProductSpecificationsService and pushes those events down for webui
to listen to. The listeners have been hooked up in webui, but don't
currently implement any behavior. The "add" event won't be as useful
in the main feature UI, but will be used in the history/management
surface to keep the list of sets a user has up to date.
Bug: b:333378234
Change-Id: I093c26c04ae65f3361fd3558f96e35185ff720ef
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5492300
Reviewed-by: Emily Shack <emshack@chromium.org>
Commit-Queue: Matthew Jones <mdjones@chromium.org>
Reviewed-by: Brendon Tiszka <tiszka@chromium.org>
Reviewed-by: Paul Adedeji <pauladedeji@google.com>
Cr-Commit-Position: refs/heads/main@{#1294952}
[Extensions Cleanup] Remove unused CheckMediaAccessPermission()
Bug: n/a
Change-Id: Id8fddd9d6818071baae85293f6c1be3468a6633f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5503426
Reviewed-by: David Bertoni <dbertoni@chromium.org>
Commit-Queue: David Bertoni <dbertoni@chromium.org>
Auto-Submit: Emilia Paz <emiliapaz@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1294951}
[Interop] Expose section element as generic role
According to [1], section without an accessible name should be mapped to
the generic role. It was previously mapped to the section role.
kGenericContainer cannot be used since it does not properly reset the
counts for setSize and posInSet (see [2] for an example). Therefore, a
new role, kSectionWithoutName is created.
This change also fixes the el-section-no-name subtest in
wpt/html-aam/roles-contextual.html.
[1] https://www.w3.org/TR/html-aam-1.0/#el-section
[2] https://crrev.com/c/chromium/src/+/5318834/14/content/test/data/accessibility/html/input-radio-expected-blink.txt
Bug: 325975937, 41490744, 335886104
Change-Id: I44b3aab2d3c0f4fb21bedc0d2461e85dc4d7c938
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5318834
Commit-Queue: Jocelyn Tran <jocelyntran@google.com>
Reviewed-by: David Tseng <dtseng@chromium.org>
Reviewed-by: Joe Mason <joenotcharles@google.com>
Reviewed-by: Aaron Leventhal <aleventhal@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1294950}
snap-group: Add desks switching with shortcut unit test
Demo: http://b/334221704#comment1
Fixed: b/334221704
Test: Added unit test + manually
Change-Id: I23c89b7eddd20d1c10178fbc0a751acea5c7bace
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5503500
Commit-Queue: Michele Fan <michelefan@chromium.org>
Reviewed-by: Sammie Quon <sammiequon@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1294949}
Roll Media App from aGzj1tUzi8I3b_QxN... to 033IU3fKLfUjVc42N...
Release_Notes: http://go/media_app-x20/relnotes/Main/media_app_202405010800_RC00.html
https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/media_app/app/+/033IU3fKLfUjVc42N_ZesPuEWs3_5c6F-Jz-xyaiOSAC
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/media-app-chromium-autoroll
Please CC cros-essential-apps-dev@chromium.org,jomag@google.com,media-app@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:chromeos-betty-pi-arc-chrome;luci.chrome.try:linux-chromeos-chrome
Bug: None
Tbr: media-app@grotations.appspotmail.com
Change-Id: Id32f9011a5ce3901b916a4f89b12bdf685b39c67
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5504513
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1294948}
Open and delete menu items for revisit surface.
Bug: 324935631
Change-Id: I1cae3f0281ab32e1b3555b3652be5a45f7762939
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5503100
Reviewed-by: Calder Kitagawa <ckitagawa@chromium.org>
Commit-Queue: Sky Malice <skym@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1294947}
[Extensions] Add a test for user script injection order
Add a few tests exercising user script injection order, including:
* Injection order of scripts from different userScripts.register() calls
* Injection order of scripts from the same userScripts.register() call
* Injection order of code pieces within the same user script definition
These are currently inconsistent with one another. We should likely
change that. This adds a test as (internal) documentation.
Bug: 337078958
Change-Id: If46033d9a743077e15042e47b238e352a11fec49
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5503811
Reviewed-by: Emilia Paz <emiliapaz@chromium.org>
Commit-Queue: Devlin Cronin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1294946}
WebUI: Add cr-progress, replacement for paper-progress
cr-progress does not implement the "secondaryProgress" portion of
paper-progress as this was not used anywhere.
This CL also updates the WebUI gallery to use cr-progress instead
of paper-progress.
Bug: 40943652
Change-Id: Ia361947010355e83b013d34cb30523b3216e1932
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5502809
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1294945}
Add more detailed logging for history embedding metrics and search time
This CL adds VLOG calls so the team can see log output even in release
Canary builds when run using command line with vmodule parameter, e.g.
`--vmodule=*/history_embeddings/*=2` to show VLOG output from .cc files
within history_embeddings component (including vector_database.cc).
Some UMA samples are output, as well as some search time stats. The
search time is broken down so we can see precisely how much time is
spent on loading and iteration versus scoring computation. Note that
some systems have more precise clocks than others, and a more precise
clock can report a more accurate division of scoring versus iteration.
Bug: 325108118
Change-Id: I306740191b6887832f7fda7444e085475c40c643
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5503424
Reviewed-by: Orin Jaworski <orinj@chromium.org>
Reviewed-by: John Lee <johntlee@chromium.org>
Commit-Queue: Orin Jaworski <orinj@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1294944}
[gbb-cct] Update button config list to reflect the client signed-out use case and custom params are not provided
Bug: b/329454646
Change-Id: I0450ccd7f4c9b22beb783c88da9b55816e50fb93
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5505533
Reviewed-by: Jinsuk Kim <jinsukkim@chromium.org>
Commit-Queue: Emilia Palaghita <pemilia@google.com>
Reviewed-by: Edmund Wright <edmundw@google.com>
Cr-Commit-Position: refs/heads/main@{#1294943}
Remove unused ExclusiveAccessContext::UpdateFullscreenToolbar()
Also remove unused include and add/update some comments.
Change-Id: Ifdbd8376abae3019f6dfef0ef3d0e9f65633c55d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5503314
Auto-Submit: Mike Wasserman <msw@chromium.org>
Reviewed-by: Brad Triebwasser <btriebw@chromium.org>
Commit-Queue: Mike Wasserman <msw@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1294942}
Put platform_thread.h include of feature_list.h behind a cros build flag
This include is fairly expensive according to
https://commondatastorage.googleapis.com/chromium-browser-clang/include-analysis.html#view=edges
It's only used within cros code, so we now only include it on cros.
Bug: 40318405
Change-Id: Ib9c14daf39ff39092bd276453a2726cafa49fc99
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5503191
Commit-Queue: Nico Weber <thakis@chromium.org>
Auto-Submit: Kevin McNee <mcnee@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Owners-Override: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1294941}
Revert "[Android] Complete support for AppMenus in Public Transit"
This reverts commit e6bb5cb552d2350c8debee6c037839301b13ff6e.
Reason for revert: Likely cause of CI failures: https://b.corp.google.com/issues/338229156
Original change's description:
> [Android] Complete support for AppMenus in Public Transit
>
> Add all expected menu items to HubTabSwitcherAppMenuFacility as an
> example.
>
> When in an empty state (no regular tabs), Select Tabs and Close All
> Tabs do not appear in android-12l-x64-dbg but appear disabled in
> android-x86-rel, which is a bit surprising and led to a brief
> breakage. They are now added as gated ViewElements.
>
> Create a generic ScrollableFacility with how scrolling should be
> handled where necessary. An intermediate ItemScrolledTo facility
> represents the state between scroll and select.
>
> Cq-Include-Trybots: luci.chromium.try:android-12l-x64-dbg
> Bug: 328275348,41489965,328275621,329106755
> Change-Id: I5ca37afc2f35fac6be32b1aae9c29991b77e5a7f
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5498817
> Reviewed-by: Andrew Grieve <agrieve@chromium.org>
> Commit-Queue: Henrique Nakashima <hnakashima@chromium.org>
> Reviewed-by: Calder Kitagawa <ckitagawa@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1294690}
Bug: 328275348,41489965,328275621,329106755,338229156
Change-Id: Iecc037315b8efb9fa127cbd61fa5ea5a9be44481
Cq-Include-Trybots: luci.chromium.try:android-12l-x64-dbg
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5505736
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Auto-Submit: Ian Wells <iwells@chromium.org>
Commit-Queue: Ian Wells <iwells@chromium.org>
Owners-Override: Ian Wells <iwells@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1294940}
Revert "Split shared state out of DawnContextProvider"
This reverts commit c16abb5d1f3a4f400827af98064c4767752b8147.
Reason for revert: Broke the build :(
See https://ci.chromium.org/ui/p/chromium/builders/ci/android-webview-13-x64-hostside-rel/2990/overview for first failure.
Compilation failure is:
FAILED: 860ea542-a177-4b41-8cd5-09863a589e53 "./libmonochrome_64__combined.so" SOLINK ./libmonochrome_64__combined.so
stderr:
ld.lld: error: undefined symbol: gpu::DawnContextProvider::backend_type() const
>>> referenced by wrapped_sk_image_backing_factory.cc:57 (../../gpu/command_buffer/service/shared_image/wrapped_sk_image_backing_factory.cc:57)
>>> gles2_sources/wrapped_sk_image_backing_factory.o:(gpu::WrappedSkImageBackingFactory::WrappedSkImageBackingFactory(scoped_refptr<gpu::SharedContextState>)) in archive obj/gpu/command_buffer/service/libgles2_sources.a
>>> referenced by wrapped_sk_image_backing_factory.cc:57 (../../gpu/command_buffer/service/shared_image/wrapped_sk_image_backing_factory.cc:57)
>>> gles2_sources/wrapped_sk_image_backing_factory.o:(gpu::WrappedSkImageBackingFactory::IsSupported(unsigned int, viz::SharedImageFormat, gfx::Size const&, bool, gfx::GpuMemoryBufferType, gpu::GrContextType, base::span<unsigned char const, 18446744073709551615ul, unsigned char const*>)) in archive obj/gpu/command_buffer/service/libgles2_sources.a
>>> referenced by shared_context_state.cc:148 (../../gpu/command_buffer/service/shared_context_state.cc:148)
>>> gles2_sources/shared_context_state.o:(gpu::SharedContextState::InitializeSkia(gpu::GpuPreferences const&, gpu::GpuDriverBugWorkarounds const&, gpu::raster::GrShaderCache*, gpu::GpuProcessShmCount*, gl::ProgressReporter*)) in archive obj/gpu/command_buffer/service/libgles2_sources.a
clang++: error: linker command failed with exit code 1 (use -v to see invocation)
Original change's description:
> Split shared state out of DawnContextProvider
>
> There needs to be a DawnContextProvider per thread for DrDC to work for
> Graphite/Dawn/Vulkan. With Dawn/Vulkan the wgpu::Instance+Adapter+Device
> can be shared between the graphite contexts. This splits DawnSharedState
> out of DawnContextProvider to accomplish this shared ownership.
>
> This change should be a no-op since DawnContextProvider holds
> the only ref to DawnSharedState. A follow up will change that when DrDC
> is enabled so that two DawnContextProviders reference the same
> DawnSharedState.
>
> Bug: 40945609
> Change-Id: I7b630276d7b329c77d30644dae59e641fbf3d787
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5497715
> Commit-Queue: Kyle Charbonneau <kylechar@chromium.org>
> Reviewed-by: Sunny Sachanandani <sunnyps@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1294930}
Bug: 40945609
Change-Id: Ibf39406445b5fc4dc0f807deeafba321448f3dcb
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5504551
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Auto-Submit: Ian Clelland <iclelland@chromium.org>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Owners-Override: Ian Clelland <iclelland@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1294939}
Make find-in-page inert check look at flat tree
This patch didn't look at the flat tree, so it regressed the case where
dialogs are in a shadowroot and the case where text is slotted into a
dialog: http://crrev.com/1270044
Fixed: 336832613
Change-Id: Id592aee16774e92d96e695558365b5715900aab9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5502209
Reviewed-by: Oriol Brufau <obrufau@igalia.com>
Commit-Queue: Joey Arhar <jarhar@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1294938}
Roll Depot Tools from e75b940aeabc to 19199514e8ea (1 revision)
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/e75b940aeabc..19199514e8ea
2024-05-01 sokcevic@chromium.org [gsutil] Fix race when downloading gsutil
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/depot-tools-chromium-autoroll
Please CC ajp@google.com,aravindvasudev@google.com,gavinmak@google.com,sokcevic@chromium.org on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: chromium:338040708
Tbr: ajp@google.com,aravindvasudev@google.com,gavinmak@google.com,sokcevic@chromium.org
Change-Id: I1e135d0b5f78e784aea52210dc27fe1b21508c2e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5506014
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1294937}
GCMNativeBackgroundTask: add finch trial to fieldtrial_testing_config
Bug: 41490045
Change-Id: I7199b03d4020e30276b064b02d8bd19ba3fab10d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5505734
Auto-Submit: Sam Maier <smaier@chromium.org>
Commit-Queue: Henrique Nakashima <hnakashima@chromium.org>
Reviewed-by: Henrique Nakashima <hnakashima@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1294936}
Don't use SCK API in situations where it's known to not work
The new SCK API is known to not work if there is more than one copy of
Chromium running at a time.
Bug: 335449467
Bug: 333443445
Change-Id: I33a187c7a53a6b1d7432b9a2611757c7f08fd244
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5503231
Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
Commit-Queue: Avi Drissman <avi@chromium.org>
Reviewed-by: Leonard Grey <lgrey@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1294935}
android: Allow auto-applying expectations patches
Added REBASELINE_PROGUARD environment variable to allow
auto-rebaselining of proguard expectations. Cronet already had its own
REBASELINE_CRONET_PROGUARD. Allow Cronet to also recognize
REBASELINE_PROGUARD as well.
Bug: 338060678
Change-Id: I56b8b5d5e352c15f2fdcddfc829ff669f7ef626b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5502789
Reviewed-by: Mohannad Farrag <aymanm@google.com>
Commit-Queue: Peter Wen <wnwen@chromium.org>
Auto-Submit: Peter Wen <wnwen@chromium.org>
Reviewed-by: Mohamed Heikal <mheikal@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1294934}
[ios] Migrates assets to bundle_data_xcassets [2/N].
Removes an unused fullcolor_branding_icon image from autofill.
Bug: 332929378
Change-Id: Ia9ebff4512183ca7496620670260bab59df4a7fe
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5502793
Reviewed-by: Justin Cohen <justincohen@chromium.org>
Commit-Queue: Rohit Rao <rohitrao@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1294933}
CrOS Settings: Apply clearBody() to remaining browser tests
Bug: b:335269196
Change-Id: I44873c4afb785ac3832fc94e79890fb81066ca7d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5500076
Auto-Submit: Wes Okuhara <wesokuhara@google.com>
Reviewed-by: Nikki Moteva <moteva@google.com>
Commit-Queue: Nikki Moteva <moteva@google.com>
Cr-Commit-Position: refs/heads/main@{#1294932}
Delete Flex OOBE config when a device finishes registering
We trigger the DeleteFlexOobeConfig DBus method from
StartupUtils::MarkDeviceRegistered. MarkDeviceRegistered is called
whenever the .oobe_completed flag is set; for our purposes, this
includes successful enrollment (after either Flex Auto enrollment
or manual fallback) or completion of consumer OOBE.
MarkDeviceRegistered is also called when a user enters guest mode in
OOBE. While this technically could lead to the Flex token being deleted
before the device is out of OOBE, we're guaranteed to do state
determination and attempt Flex Auto Enrollment before the user has an
opportunity to enter guest mode, so this situation only arises after the
token has been recognized as revoked by the server (at which point we
don't care if it gets deleted a little early).
Test: unit_tests --gtest_filter=*EnrollmentScreen*
Test: unit_tests --gtest_filter=*StartupUtils*
Bug: b/334161896
Change-Id: Ic8cd1ddf40563312065d49e3ce8d2785046f266d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5479731
Reviewed-by: Danila Kuzmin <dkuzmin@google.com>
Reviewed-by: Yves Arrouye <drcrash@chromium.org>
Commit-Queue: Jackson Tadie <jacksontadie@google.com>
Reviewed-by: Artem Sumaneev <asumaneev@google.com>
Cr-Commit-Position: refs/heads/main@{#1294931}
Split shared state out of DawnContextProvider
There needs to be a DawnContextProvider per thread for DrDC to work for
Graphite/Dawn/Vulkan. With Dawn/Vulkan the wgpu::Instance+Adapter+Device
can be shared between the graphite contexts. This splits DawnSharedState
out of DawnContextProvider to accomplish this shared ownership.
This change should be a no-op since DawnContextProvider holds
the only ref to DawnSharedState. A follow up will change that when DrDC
is enabled so that two DawnContextProviders reference the same
DawnSharedState.
Bug: 40945609
Change-Id: I7b630276d7b329c77d30644dae59e641fbf3d787
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5497715
Commit-Queue: Kyle Charbonneau <kylechar@chromium.org>
Reviewed-by: Sunny Sachanandani <sunnyps@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1294930}
Roll src-internal from d4ebf5b40556 to 3a4034e085e7 (1 revision)
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/d4ebf5b40556..3a4034e085e7
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC beverloo@google.com,chrome-browser-infra-team,iclelland@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: chromium:40258588
Tbr: beverloo@google.com,iclelland@google.com
Change-Id: Ibd7ab144219b78b57b89f9a4870f8fb314e4246b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5505377
Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1294929}
Automatic update from google3
Automatic update for 2024-05-01 UTC
Change-Id: Iede2232c6adeb0b40ec9cffc2b9b3a5c8f63cc51
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5504601
Bot-Commit: PKI Metadata Updates Bot <mdb.chrome-pki-metadata-release-jobs@google.com>
Commit-Queue: PKI Metadata Updates Bot <mdb.chrome-pki-metadata-release-jobs@google.com>
Cr-Commit-Position: refs/heads/main@{#1294928}
Tapping on groups in revisit pane opens a dialog.
Bug: 324935631
Change-Id: I6bd0a2ab9521fdbad67015eb597782885f37c71f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5503212
Reviewed-by: Calder Kitagawa <ckitagawa@chromium.org>
Commit-Queue: Sky Malice <skym@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1294927}
Roll Dawn from 1488c9c94dea to 7032654d545b (2 revisions)
https://dawn.googlesource.com/dawn.git/+log/1488c9c94dea..7032654d545b
2024-05-01 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll Depot Tools from 765b75b4c081 to e75b940aeabc (2 revisions)
2024-05-01 penghuang@chromium.org d3d11: support devices which don't support monitored fence
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dawn-chromium-autoroll
Please CC cwallez@google.com,enga@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chromium.try:dawn-android-arm-deps-rel;luci.chromium.try:dawn-android-arm64-deps-rel;luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-mac-arm64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel;luci.chromium.try:dawn-win11-arm64-deps-rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:gpu-fyi-cq-android-arm64
Bug: chromium:335553337
Tbr: enga@google.com
Include-Ci-Only-Tests: true
Change-Id: I0397571bbd4209d64a2aca8cd2e6eafa73f2b848
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5505875
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1294926}
diagnostics: Convert memory_card_test to TS
Bug: b/245336251
Change-Id: Ie05a8f767bc4bca13c19f0fc01479007d97070f8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5457015
Commit-Queue: Michael Checo <michaelcheco@google.com>
Reviewed-by: Camden Bickel <cambickel@google.com>
Cr-Commit-Position: refs/heads/main@{#1294925}
Roll Chrome Mac Arm PGO Profile
Roll Chrome Mac Arm PGO profile from chrome-mac-arm-main-1714570552-cc1af58c5998fe99533b33e12b78c7fa9917ad57-5db8a14cabce36adaa77534082222d72728c3b97.profdata to chrome-mac-arm-main-1714579013-c07dede27014baa47c63805c8f3cc7c9c1425fd0-8c7d7dc72c79f558aefe1b9390652776b74de9a1.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-arm-chromium
Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:mac-chrome
Tbr: pgo-profile-sheriffs@google.com
Change-Id: I139e617ac149b27d751acf03bcf1f8bf1466182e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5505383
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1294924}
[Blink] Update Buganizer GetIssueList API response parsing
GetIssueList request return list of issue in the same structure as the
payload returned from CreateIssue [1], so it should be parsed the same
way before returning to the caller.
[1]: http://google3/google/devtools/issuetracker/v1/issuetracker_service.proto;l=1814;rcl=623266776
Change-Id: I5e01e8ab761745811f9b423baf6c35658796ce21
Bug: 335457566
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5501448
Reviewed-by: Jonathan Lee <jonathanjlee@google.com>
Reviewed-by: Weizhong Xia <weizhong@google.com>
Commit-Queue: An Sung <ansung@google.com>
Cr-Commit-Position: refs/heads/main@{#1294923}
Revert "Split app_service/webapk into its own BUILD.gn file."
This reverts commit 306478860b1f3f23e10b6c4ad54436863bbce0c4.
Reason for revert: https://g-issues.chromium.org/issues/338220073
Original change's description:
> Split app_service/webapk into its own BUILD.gn file.
>
> This creates a new BUILD.gn file for app_service/webapk which is
> unidirectionally depended on by the App Service. As part of this,
> webapk_manager.{h,cc} is moved to the app_service directory as it
> depends on App Service, avoiding a dependency cycle.
>
> Bug: b/336172688
> Change-Id: I5f16ab2bcbf1c9ab91465fab53e13c20c5b6e228
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5495189
> Reviewed-by: Tim Sergeant <tsergeant@chromium.org>
> Commit-Queue: Dominick Ng <dominickn@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1294740}
Bug: b/336172688
Change-Id: Iece71b427bd1c57d086c12207ba26b8d75a5c29a
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5504734
Reviewed-by: Haiyang Pan <hypan@google.com>
Auto-Submit: Ian Wells <iwells@chromium.org>
Commit-Queue: Haiyang Pan <hypan@google.com>
Owners-Override: Ian Wells <iwells@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1294922}
[lensoverlay] Fix issue with URL-escaped query value.
In crrev.com/c/5462882, we implemented searchbox searches by extracting
the query from the searchbox's suggestion URL but we didn't unescape
that value so the value would still be URL escaped (for example,
"my+query" instead of "my query"). This was fine[1] but in
crrev.com/c/5493595 we started pushing that value back to the searchbox,
revealing the original issue.
[1] Probably? It may be causing subtle issues server-side.
Bug: b:338037795
Change-Id: I715ed907b643373d875f3248ce9ceeeab11b8c82
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5502816
Commit-Queue: Justin Donnelly <jdonnelly@chromium.org>
Reviewed-by: Jason Hu <hujasonx@google.com>
Cr-Commit-Position: refs/heads/main@{#1294921}
Don't create redundant page text copies, replace with RefCountedString16
Feed the PageCaptured(...) consumers with a ref-counted string of the
page text instead of cloning.
Change-Id: Idc4eabe3ec38e7d0d8953d64f9a2fa0987993cf9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5491252
Auto-Submit: Zinovy Nis <zynis@yandex-team.ru>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Daniel Rubery <drubery@chromium.org>
Reviewed-by: Anthony Cui <cuianthony@chromium.org>
Reviewed-by: thefrog <thefrog@chromium.org>
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Commit-Queue: Basia Zimirska <basiaz@google.com>
Reviewed-by: Basia Zimirska <basiaz@google.com>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Reviewed-by: Robert Ogden <robertogden@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1294920}
FLEDGE: Fix tracing crash with certain timing of cumulative timeout
In particular, we won't actually have started tracing on all BidStates
if timeout happened while only some of them have received
OnWorkletReceived notifications, due to there being so many they got
split up to release the thread.
Bug: 336342803
Change-Id: Icde3b9211c83f92676cbe7373fdae3cc4358e072
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5497626
Reviewed-by: Caleb Raitto <caraitto@chromium.org>
Commit-Queue: Maks Orlovich <morlovich@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1294919}
Enable fast affine bitmap blitters on NEON
Activates the code from: http://review.skia.org/844816
These are quicker than the general purpose routines in certain cases
(particularly when decoding+rotating EXIF-rotated images, for example).
Bug: b/329003512
Change-Id: I97771f39b2ef4bd114a66092bd4d571f34900173
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5473368
Reviewed-by: Michael Ludwig <michaelludwig@google.com>
Auto-Submit: Brian Osman <brianosman@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
Commit-Queue: Michael Ludwig <michaelludwig@google.com>
Cr-Commit-Position: refs/heads/main@{#1294918}
Split out Profile-dependent initialization tasks from Application level tasks.
Bug: 337037827
Change-Id: I849135fa71caddc06652b4f6d2fe663099280f5a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5497576
Reviewed-by: David Maunder <davidjm@chromium.org>
Commit-Queue: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1294917}
[Media Preview] Add check for origin trial before showing media
preview.
Media Previews will be controlled by a reverse origin trial. [*]
This CL uses the reverse OT to disable media previews.
[*] https://chromestatus.com/feature/5100528783851520
Bug: 335703168
Change-Id: Id54af5c643fdc97416b2844a44f8c17b47c86efc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5466332
Reviewed-by: Stefan Zager <szager@chromium.org>
Commit-Queue: Mark Foltz <mfoltz@chromium.org>
Reviewed-by: Ahmed Moussa <ahmedmoussa@google.com>
Reviewed-by: Bryant Chandler <bryantchandler@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1294916}
Remove deprecated UsageStatsService getInstance method.
All downstream clients have migrated to the profile-aware API.
Bug: 40254448
Cq-Include-Trybots: luci.chrome.try:android-internal-rel
Change-Id: I006ba360f5f62da4013c110700b610b7c2e2c641
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5503378
Commit-Queue: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Patrick Noland <pnoland@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1294915}
[ImprovedDownloadWarnings] Enable chrome://downloads updates by default
This enables the feature kImprovedDownloadPageWarnings by default, and
removes its fieldtrial testing config.
See launch/4273322.
Bug: 40067647
Change-Id: I388755344694b8bf54038ff4633fb29d8bab73eb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5503232
Reviewed-by: Daniel Rubery <drubery@chromium.org>
Commit-Queue: Daniel Rubery <drubery@chromium.org>
Auto-Submit: Lily Chen <chlily@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1294914}
Revert "Enable UsedColorSchemeRootScrollbars feature"
This reverts commit f086db0f5117a6c32a6b4afa80a043226e51cfad.
Reason for revert: https://issues.chromium.org/issues/337904215
Original change's description:
> Enable UsedColorSchemeRootScrollbars feature
>
> I2S: https://groups.google.com/a/chromium.org/g/blink-dev/c/UdOQkoMJYnY
> Chromestatus: https://chromestatus.com/feature/5089486318075904
>
> Bug: 40259909
> Change-Id: I6da2fe5e30237748d29df6171e7a6a80e659c0b1
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5406829
> Reviewed-by: Robert Flack <flackr@chromium.org>
> Commit-Queue: Yaroslav Shalivskyy <yshalivskyy@microsoft.com>
> Reviewed-by: Olga Gerchikov <gerchiko@microsoft.com>
> Cr-Commit-Position: refs/heads/main@{#1282111}
Bug: 40259909, 337904215
Change-Id: I74e34a443c8478e99151ac8ec5e261c5481101ff
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5501644
Reviewed-by: Robert Flack <flackr@chromium.org>
Commit-Queue: Yaroslav Shalivskyy <yshalivskyy@microsoft.com>
Cr-Commit-Position: refs/heads/main@{#1294913}
[ TabRestore ] Serialize Saved Group Id for saved groups / tabs
Update the tab restore Tab and Group pickles to keep track of the saved group id. This must be done to prevent duplicating a saved group when we restore an entry after the browser has been restarted.
Change-Id: I90a6724e7890bb8a8b1502e95e5d2adb427f1f3b
Bug: 330769691, 330769723
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5498867
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Eshwar Stalin <estalin@chromium.org>
Commit-Queue: Darryl James <dljames@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1294912}
ScriptPromise constructor should take a v8::Promise instead of v8::Value
Change-Id: Ib75f3485679f21b262ebdd499e5487cf7aef3839
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5492293
Commit-Queue: Nate Chapin <japhet@chromium.org>
Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1294911}