Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Navigation Block: Data View #16812

Closed
mtias opened this issue Jul 30, 2019 · 2 comments · Fixed by #17265
Closed

Navigation Block: Data View #16812

mtias opened this issue Jul 30, 2019 · 2 comments · Fixed by #17265
Assignees
@talldan
Labels
[Block] Navigation Affects the Navigation Block [Feature] List View Menu item in the top toolbar to select blocks from a list of links. [Status] In Progress Tracking issues with work in progress [Type] Enhancement A suggestion for improvement.

Comments

@mtias
Copy link
Member

mtias commented Jul 30, 2019

Regardless of how the UI evolves for this block, I think there will always be a need for representing the menu structure as a child block tree with all menu hierarchies mapped out consistently and not hidden (dropdowns, etc).

Luckily, we already have a view that handles that representation in the "block navigator". That means if the navigation menu block is represented through child blocks, we'll get this view for free. Furthermore, if we allow drag and drop to reorder items in the navigator (see #11408) we'll also inherit it, making interactions more reliable and consistent with much higher chances of shared improvements and accessibility.

We can also probably look at rendering this view inline or in a modal from the navigation menu block itself.
@mtias mtias added [Feature] List View Menu item in the top toolbar to select blocks from a list of links. [Block] Navigation Affects the Navigation Block and removed [Feature] List View Menu item in the top toolbar to select blocks from a list of links. labels Jul 30, 2019
@karmatosed karmatosed added this to To Do in Navigation editor via automation Jul 30, 2019
This was referenced Jul 30, 2019
Closed
Closed
@talldan talldan added [Type] Enhancement A suggestion for improvement. [Feature] List View Menu item in the top toolbar to select blocks from a list of links. labels Aug 30, 2019
@talldan talldan self-assigned this Aug 30, 2019
@talldan talldan added the [Status] In Progress Tracking issues with work in progress label Aug 30, 2019
@talldan
Copy link
Contributor

talldan commented Aug 30, 2019

I'll pick this up. To start with I'll stick with a toolbar button that opens the block navigator (for the current nav block) in a modal.

@talldan talldan moved this from To Do to In Progress in Navigation editor Aug 30, 2019
@talldan talldan mentioned this issue Aug 30, 2019
Merged
5 tasks
@talldan
Copy link
Contributor

talldan commented Aug 30, 2019 •
edited

I've knocked together a PR (#17265). Would be great to get some testing on it and think about how we want it to evolve.

Navigation editor automation moved this from In Progress to Done Sep 5, 2019
@noisysocks noisysocks removed this from Done in Navigation editor Sep 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@talldan talldan

Labels
[Block] Navigation Affects the Navigation Block [Feature] List View Menu item in the top toolbar to select blocks from a list of links. [Status] In Progress Tracking issues with work in progress [Type] Enhancement A suggestion for improvement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add navigator for nav block WordPress/gutenberg
2 participants
@mtias @talldan