This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
Remove code corresponding to always defined symbols #9542
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
No need to review this yet, I"ll carry on for the undefines. |
danmoseley
force-pushed
the
defines3
branch
3 times, most recently
from
40b0964
to
e424bba
Compare
…quire it to be defined
|
This is halfway. @jkotas @gkhanna79 I'm going to take a break at this point, if you'd like to review. |
|
Please let's not squash on merge, obviously. |
|
FEATURE_CODEPAGES_FILE: delete nlstable.h as well |
|
FEATURE_APPX_BINDER: Delete |
|
FEATURE_FUSION: Delete |
|
LGTM otherwise. Thank you for doing this! |
|
@dotnet-bot test osx x64 checked build and test (https://github.com/dotnet/coreclr/issues/9388) |
|
@danmosemsft have you seen my comment on your other PR? I noticed that in at least one case only the |
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
Remove code corresponding to always defined symbols Commit migrated from dotnet/coreclr@2efbb92
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to https://github.com/dotnet/coreclr/issues/9067