Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement set/get model constraints #253

Merged
merged 2 commits into from Jul 23, 2018

Conversation

gnuoy
Copy link
Contributor

@gnuoy gnuoy commented Jul 12, 2018

Add methods for setting and getting model constraints.

Liam Young added 2 commits July 12, 2018 17:32
Add methods for setting and getting model constraints.
Copy link
Contributor

@thedac thedac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FWIW +1

@gnuoy
Copy link
Contributor Author

gnuoy commented Jul 13, 2018

I think the ci failures are unrelated to this change

@johnsca
Copy link
Contributor

johnsca commented Jul 23, 2018

Yeah, I think the failures were due to an upstream issue with Juju edge which is resolved now. Re-running just to be sure, but +1 and will go ahead and merge.

@johnsca johnsca merged commit 26c86c8 into juju:master Jul 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants